From 0f6edd7410db4c1a8cfe1bc1b7cc598487d6b853 Mon Sep 17 00:00:00 2001
From: Owen Diehl <ow.diehl@gmail.com>
Date: Fri, 11 Oct 2024 15:18:50 -0700
Subject: [PATCH] tmp Signed-off-by: Owen Diehl <ow.diehl@gmail.com>

---
 pkg/dash/dash.go    | 40 +++++++++++++++++++++-------------------
 pkg/dash/metrics.go |  2 +-
 2 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/pkg/dash/dash.go b/pkg/dash/dash.go
index 4b7d9753d22e8..222179eee473d 100644
--- a/pkg/dash/dash.go
+++ b/pkg/dash/dash.go
@@ -13,7 +13,6 @@ import (
 	"github.com/grafana/grafana-foundation-sdk/go/common"
 	"github.com/grafana/grafana-foundation-sdk/go/dashboard"
 	"github.com/grafana/grafana-foundation-sdk/go/prometheus"
-	"github.com/grafana/grafana-foundation-sdk/go/table"
 	"github.com/grafana/grafana-foundation-sdk/go/text"
 	"github.com/grafana/grafana-foundation-sdk/go/timeseries"
 	prom "github.com/prometheus/client_golang/prometheus"
@@ -125,7 +124,10 @@ func (l *DashboardLoader) writesDashboard() (dashboard.Dashboard, error) {
 		WithVariable(
 			dashboard.NewDatasourceVariableBuilder("prometheus_datasource").
 				Label("Prometheus datasource").
-				Type("prometheus"),
+				Type("prometheus").Current(dashboard.VariableOption{
+				Text:  dashboard.StringOrArrayOfString{String: cog.ToPtr("default")},
+				Value: dashboard.StringOrArrayOfString{String: cog.ToPtr("default")},
+			}),
 		)
 
 	l.WelcomeRow(objectStorage, builder)
@@ -187,24 +189,20 @@ func (l *DashboardLoader) WelcomeRow(objectStorage *ObjectStorageMetrics, builde
 
 	var targets []cog.Builder[variants.Dataquery]
 	for _, l := range requiredLabels {
-		targets = append(
-			targets,
-			prometheus.NewDataqueryBuilder().
-				Instant().
-				Datasource(dashboard.DataSourceRef{
-					Type: cog.ToPtr("prometheus"),
-					Uid:  cog.ToPtr("$prometheus_datasource"),
-				}).
-				Expr(
-					fmt.Sprintf(
-						`absent(sum(loki_build_info{%s!=""}))`,
-						l,
-					),
-				).LegendFormat(l),
-		)
+		target := prometheus.NewDataqueryBuilder().
+			Expr(
+				fmt.Sprintf(
+					`absent(sum(loki_build_info{%s!=""}))`,
+					l,
+				),
+			).
+			LegendFormat(l).
+			Instant()
+
+		targets = append(targets, target)
 	}
 
-	panel := table.NewPanelBuilder().
+	panel := timeseries.NewPanelBuilder().
 		Span(8).
 		Title("Missing required labels").
 		Description("Required labels not present on Loki instances").
@@ -212,7 +210,11 @@ func (l *DashboardLoader) WelcomeRow(objectStorage *ObjectStorageMetrics, builde
 			Type: cog.ToPtr("prometheus"),
 			Uid:  cog.ToPtr("$prometheus_datasource"),
 		}).
-		Targets(targets)
+		Targets(targets).Legend(
+		common.NewVizLegendOptionsBuilder().
+			IsVisible(true).
+			DisplayMode(common.LegendDisplayModeList),
+	)
 
 	builder.WithPanel(panel)
 }
diff --git a/pkg/dash/metrics.go b/pkg/dash/metrics.go
index 5d3c0da7be443..c1d7f2ac81ebf 100644
--- a/pkg/dash/metrics.go
+++ b/pkg/dash/metrics.go
@@ -42,7 +42,7 @@ type DependencyLoader interface {
 var DummyLoader = NewSimpleMetricLoader(config.SchemaConfig{
 	Configs: []config.PeriodConfig{
 		{
-			ObjectType: "gcs",
+			ObjectType: "s3",
 		},
 	},
 })