Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden http store server against malicios urls #77

Open
pablochacin opened this issue Dec 13, 2024 · 0 comments
Open

harden http store server against malicios urls #77

pablochacin opened this issue Dec 13, 2024 · 0 comments
Labels
security The issue is related to a security vulnerability

Comments

@pablochacin
Copy link
Collaborator

After the refactoring introduced in #76 the sanitizePath method, moved from the file store to a utility method, can no longer check the path passed points to a file within the data store directory. The corresponding test was disabled.

This creates a security risk that a forged URL could download any file using the store server.

The risk is mitigated because the store server does not get the URL to the file directly from user-supplied input. The URL is obtained from the object store using the object ID.

@pablochacin pablochacin added the security The issue is related to a security vulnerability label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security The issue is related to a security vulnerability
Projects
None yet
Development

No branches or pull requests

1 participant