Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get property value query editor settings #328

Closed
hwandersman opened this issue Jun 13, 2024 · 1 comment · Fixed by #343
Closed

Get property value query editor settings #328

hwandersman opened this issue Jun 13, 2024 · 1 comment · Fixed by #343
Assignees

Comments

@hwandersman
Copy link
Collaborator

What happened:
Get property value query displays settings for the quality, time ordering, and format, when none are used.

What you expected to happen:
Should not display these settings since there is no use for these in the API: https://docs.aws.amazon.com/iot-sitewise/latest/APIReference/API_GetAssetPropertyValue.html

This will lead to a confusing experience for customers.

How to reproduce it (as minimally and precisely as possible):

  1. Add a Get property value query in the query editor
  2. Try to set the quality, time ordering, or format and nothing changes since it is not used

Screenshots

image

Anything else we need to know?:

Environment:

  • Grafana version: 9.4.0
  • Plugin version: 1.20.0
  • OS Grafana is installed on: MacOS
  • User OS & Browser: Sonoma 14.5, Chrome
  • Others: Amazon Managed Grafana environment
@sarahzinger
Copy link
Member

Makes sense to me! Let's hide those settings, shouldn't be too difficult. Sharing with the team to prioritize a fix.

@sarahzinger sarahzinger moved this from Incoming to Next in AWS Datasources Jun 14, 2024
@iwysiu iwysiu self-assigned this Jul 26, 2024
@iwysiu iwysiu moved this from Next to In Progress in AWS Datasources Jul 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in AWS Datasources Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants