You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What happened:
Queries that do not have a refID but instead have an empty string fail to unmarshal. This is most likely because jsoniter uses an empty string to denote the end of parsing which is problematic considering "" is a valid property name/key in JSON.
What you expected to happen:
Unmarshaling should work even if the refID is empty, encoding/json handles this case: https://play.golang.com/p/KhNyYGxA7eV
How to reproduce it (as minimally and precisely as possible):
I made and pushed a failing unit test here:
What happened:
Queries that do not have a refID but instead have an empty string fail to unmarshal. This is most likely because jsoniter uses an empty string to denote the end of parsing which is problematic considering
""
is a valid property name/key in JSON.What you expected to happen:
Unmarshaling should work even if the refID is empty,
encoding/json
handles this case: https://play.golang.com/p/KhNyYGxA7eVHow to reproduce it (as minimally and precisely as possible):
I made and pushed a failing unit test here:
grafana-plugin-sdk-go/backend/json_test.go
Lines 147 to 157 in fee7ea4
The text was updated successfully, but these errors were encountered: