Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project queries are potentially very costly and become unusable due to rate limits #238

Open
mdvictor opened this issue Jul 19, 2023 · 1 comment
Labels
type/chore Chores, code refactoring or maintenance work

Comments

@mdvictor
Copy link
Contributor

mdvictor commented Jul 19, 2023

Sending GraphQL project items requests for a very large org, for example, becomes very costly, to the point where queries aren't going through anymore because of rate limits. We need to refactor and fine-tune the way we do the request so that the costs are minimal and the datasource is functional.

There are existing cases where a user can query for a couple of times before hitting the rate limit and then needs to wait an hour for the limit to refresh. More details on GitHubs limits here

e.g: for the grafana org, the cost of a query is around 100 points times the number of pages. We need to run the query times page no. because github limits us to only query batches of maximum 100 items and because of this we need to re-run the query.

@mdvictor mdvictor added the type/bug Unexpected behavior or a feature is broken label Jul 19, 2023
@mdvictor mdvictor self-assigned this Jul 19, 2023
@mdvictor
Copy link
Contributor Author

mdvictor commented Jul 25, 2023

We need to go through all the items of a project to return related ones, so the cost cannot really be lowered using our existing implementation. Maybe we could split searching for all items into searching for either issues/PRs/drafts although I think the cost wouldn't change and the search would still happen across all items

@mdvictor mdvictor removed their assignment Sep 25, 2023
@gabor gabor removed the type/bug Unexpected behavior or a feature is broken label Oct 9, 2023
@gabor gabor moved this to Backlog in OSS Big Tent Oct 27, 2023
@gabor gabor added type/feature-request Requested new feature or enhancement type/chore Chores, code refactoring or maintenance work and removed type/feature-request Requested new feature or enhancement labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Chores, code refactoring or maintenance work
Projects
Status: Backlog
Development

No branches or pull requests

2 participants