Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus.remote_write should be "unhealthy" if credentials are wrong #2269

Open
ptodev opened this issue Dec 12, 2024 · 1 comment
Open
Labels
bug Something isn't working needs-attention

Comments

@ptodev
Copy link
Contributor

ptodev commented Dec 12, 2024

What's wrong?

A user reported that they had put in wrong Mimir credentials in prometheus.remote_write, and yet the component still displayed as "healthy". I believe most people would expect it to be "unhealthy" in this case. It should probably be "unhealthy" if it receives anything other than a 2xx response from Mimir.

I'm not sure how this would work in practice though. What if every other request to Mimir is healthy? And how long do we need to wait until the last non 2xx response for the component to become healthy again?

Steps to reproduce

Use bad credentials.

System information

No response

Software version

No response

Configuration


Logs


@ptodev ptodev added the bug Something isn't working label Dec 12, 2024
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-attention
Projects
None yet
Development

No branches or pull requests

1 participant