Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alloy chart should not give itself cluster-wide secret read permissions by default #2224

Open
kallayj opened this issue Dec 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kallayj
Copy link

kallayj commented Dec 5, 2024

What's wrong?

This is a stronger variant of this issue, defining the problem as a bug rather than a feature request.

My assertion is that a helm chart should not blithely give itself permission to read all secrets across a cluster. As far as I can tell, this access level exists in order to make the remote.kubernetes.secret component "just work," but that is a component that in my view shouldn't "just work" without an explicit opt-in to exposing secrets. The documentation for this component should be updated to reflect that RBAC permissions must be given to the alloy service account to read any secrets that are to be exposed with this component. The feature enhancement requested above, if provided, should meet the opt-in need rather than enable opting out.

Unfortunately, the feature provided by grafana/k8s-monitoring-helm#224 in the k8s-monitoring chart relies on these extremely elevated default permissions, so fixing this will require breaking that chart. I will file an issue there and cross-reference it here.

Steps to reproduce

Install the chart configured with a remote.kubernetes.secret component for any secret in the cluster. Alloy will be able to read the secret without any explicit opt-in by the secret owner.

System information

No response

Software version

No response

Configuration


Logs


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant