From d25ed672fb6d5b1449c2674ddc5f9c43687105d6 Mon Sep 17 00:00:00 2001 From: matt durham Date: Mon, 5 Feb 2024 14:47:30 -0500 Subject: [PATCH 1/2] These are very unscientific bucket values. --- CHANGELOG.md | 2 ++ component/prometheus/fanout.go | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7a7599bbc329..133c074716b2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,6 +51,8 @@ Main (unreleased) - `service_name` label is inferred from discovery meta labels in `pyroscope.java` (@korniltsev) +- Changed default buckets for `agent_prometheus_fanout_latency` to `.005, .01, .05, .1, .5, 1, 5, 10, 60, 90, 600`s. (@mattdurham) + ### Bugfixes - Fix an issue in `remote.s3` where the exported content of an object would be an empty string if `remote.s3` failed to fully retrieve diff --git a/component/prometheus/fanout.go b/component/prometheus/fanout.go index 32055c01cee7..79d50c0b5c93 100644 --- a/component/prometheus/fanout.go +++ b/component/prometheus/fanout.go @@ -34,8 +34,9 @@ type Fanout struct { // NewFanout creates a fanout appendable. func NewFanout(children []storage.Appendable, componentID string, register prometheus.Registerer, ls labelstore.LabelStore) *Fanout { wl := prometheus.NewHistogram(prometheus.HistogramOpts{ - Name: "agent_prometheus_fanout_latency", - Help: "Write latency for sending to direct and indirect components", + Name: "agent_prometheus_fanout_latency", + Help: "Write latency for sending to direct and indirect components", + Buckets: []float64{.005, .01, .05, .1, .5, 1, 5, 10, 60, 90, 600}, }) _ = register.Register(wl) From f44b37219dcdfe9f1e973b589f70d0af14ed8b57 Mon Sep 17 00:00:00 2001 From: matt durham Date: Mon, 5 Feb 2024 14:49:50 -0500 Subject: [PATCH 2/2] These are very unscientific bucket values. --- CHANGELOG.md | 2 +- component/prometheus/fanout.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 133c074716b2..4c39b4697ed5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,7 +51,7 @@ Main (unreleased) - `service_name` label is inferred from discovery meta labels in `pyroscope.java` (@korniltsev) -- Changed default buckets for `agent_prometheus_fanout_latency` to `.005, .01, .05, .1, .5, 1, 5, 10, 60, 90, 600`s. (@mattdurham) +- Changed default buckets for `agent_prometheus_fanout_latency` to `.005, .01, .05, .1, .5, 1, 5, 10, 60, 90, 300`s. (@mattdurham) ### Bugfixes diff --git a/component/prometheus/fanout.go b/component/prometheus/fanout.go index 79d50c0b5c93..10a31410a5d0 100644 --- a/component/prometheus/fanout.go +++ b/component/prometheus/fanout.go @@ -36,7 +36,7 @@ func NewFanout(children []storage.Appendable, componentID string, register prome wl := prometheus.NewHistogram(prometheus.HistogramOpts{ Name: "agent_prometheus_fanout_latency", Help: "Write latency for sending to direct and indirect components", - Buckets: []float64{.005, .01, .05, .1, .5, 1, 5, 10, 60, 90, 600}, + Buckets: []float64{.005, .01, .05, .1, .5, 1, 5, 10, 60, 90, 300}, }) _ = register.Register(wl)