Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new upcoming fax API #16

Open
gehring opened this issue Jul 31, 2020 · 3 comments · May be fixed by #17
Open

Update to new upcoming fax API #16

gehring opened this issue Jul 31, 2020 · 3 comments · May be fixed by #17

Comments

@gehring
Copy link
Contributor

gehring commented Jul 31, 2020

We've made some pretty big changes to fax which will break neos. We'll be updating pypi with a new release soon but I wanted to offer to help update to the new simpler api (assuming this project is still in development). I was going to go straight for a PR but I noticed that the neos.fit module has some issues that I don't think I can properly fix without a bit of help.

The current implementation in neos.fit never allows the adam optimizer to update its state. Specifically, it always uses freshly initialized internal parameters for its scaling and momentum terms. If someone can help me better understand what constrained_bestfit_minimized is doing, I can submit a PR to both fix the bug and update to the new API.

@lukasheinrich
Copy link
Collaborator

Hi @gehring thanks so much for the offer. Yes this project is very much still active. Is there a branch on which we can preview the new API?

@gehring
Copy link
Contributor Author

gehring commented Jul 31, 2020

Yes, you should be able to see the new api on the master branch.

@gehring
Copy link
Contributor Author

gehring commented Jul 31, 2020

Oh, I should have point out that we've also updated the readme with an example which includes using a non-differentiable solver.

@gehring gehring linked a pull request Jul 31, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants