-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NativeTARDistribution usable #87
Conversation
@gilles-duboscq , can you please have a look at this |
output = join(self.suite.dir, self.output) | ||
assert tarfilename | ||
with tarfile.open(tarfilename, 'r:') as tar: | ||
log('Extract {} to {}'.format(tarfilename, output)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe s/Extract/Extracting/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
So the This feels a bit strange, how does it work when the distribution comes from a |
@gilles-duboscq only if the distribution is native the output argument is considered. And native distributions can only contain native projects. Here is the usecase:
Specifying |
Would it help if I rename the |
If you are in SourceSuite mode |
Make NativeTARDistribution more usable
So the |
…module-jars to master * commit '9d1fe9c2ac181d143fbb97118f379cd097a84a18': added sources if possible to a module jar extracted from a JDK
Fixes bugs/missing features that make NativeTARDistribution usable for binary deployment of non-java projects.