Skip to content

Commit

Permalink
[GR-48911] Remove explicit export of argparse.Action
Browse files Browse the repository at this point in the history
PullRequest: mx/1777
  • Loading branch information
patrick96 committed Apr 9, 2024
2 parents 1505791 + 943c958 commit 068de8f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
3 changes: 2 additions & 1 deletion src/mx/_impl/mx.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@
"main",
"version",
"JavaCompliance", # Re-export from mx_javacompliance
"webserver", # Re-export from mx_webserver
]

import sys
Expand Down Expand Up @@ -18146,7 +18147,7 @@ def alarm_handler(signum, frame):
_CACHE_DIR = get_env('MX_CACHE_DIR', join(dot_mx_dir(), 'cache'))

# The version must be updated for every PR (checked in CI) and the comment should reflect the PR's issue
version = VersionSpec("7.21.0") # [GR-53335] Fix arguments parsing in mx intellijinit
version = VersionSpec("7.21.1") # [GR-51531] Fix more accesses to indirect mx imports

_mx_start_datetime = datetime.utcnow()

Expand Down
2 changes: 1 addition & 1 deletion src/mx/_impl/mx_compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def __repr__(self):

def jarsUseJDKDiscriminant(self):
"""
Should `mx.JARDistribution` use the jdk version used for the build as a `Dependency._extra_artifact_discriminant`
Should `mx_jardistribution.JARDistribution` use the jdk version used for the build as a `Dependency._extra_artifact_discriminant`
to avoid collisions of build artifacts when building with different JAVA_HOME/EXTRA_JAVA_HOMES settings.
"""
return False
Expand Down
5 changes: 1 addition & 4 deletions src/mx_unittest.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@

from mx._impl.mx_unittest import __all__ as _unittest_symbols

# TODO: [GR-48911] Users should rather use argparse.Action
__legacy__ = ["Action"]

__all__ = _unittest_symbols + __legacy__
__all__ = _unittest_symbols

_redirect(
__name__,
Expand Down

0 comments on commit 068de8f

Please sign in to comment.