Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandrel 23.0.4 update #726

Merged
merged 6 commits into from
May 3, 2024
Merged

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented May 2, 2024

Partial sync with backports from graalvm-for-jdk21-community-backports.

Other than that, just a version update to 23.0.4.1 and set to release => false.

jerboaa and others added 6 commits May 2, 2024 19:39
Mark it as non-release.
(cherry picked from commit 3d0266b)
(cherry picked from commit 83c699edbfc6af7b6effeb3ad536fbc6531edf3a)
(cherry picked from commit dbf260a)
matter, in case of overflow the value is still different

(cherry picked from commit ac0fc684c9b78b337873d5789d8886cd6a93cea9)
(cherry picked from commit 432915f)
(cherry picked from commit 429b3f9fb983e98bd87b8d440c43195e4d75f0d1)
(cherry picked from commit c9530f1)
@jerboaa jerboaa requested review from Karm and zakkak May 2, 2024 17:46
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 2, 2024
@Karm
Copy link
Collaborator

Karm commented May 3, 2024

@jerboaa Hmmm,

 Warning: 2 18:30:09.922 INFO  [o.g.t.i.u.Logs] (checkLog) build-and-run.log log for quarkusFullMicroProfile contains whitelisted error: `[WARNING] [io.quarkus.deployment.configuration] Configuration property 'quarkus.package.type' has been deprecated and replaced by: [quarkus.package.jar.enabled, quarkus.package.jar.type, quarkus.native.enabled, quarkus.native.sources-only]'
Error:  Tests run: 2, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 225.911 s <<< FAILURE! - in org.graalvm.tests.integration.RuntimesSmokeTest
Error:  quarkusFullMicroProfile{TestInfo}  Time elapsed: 225.911 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: 
build-and-run.log log should not contain error or warning lines that are not whitelisted. See D:\a\mandrel\mandrel\testsuite\target\archived-logs\org.graalvm.tests.integration.RuntimesSmokeTest\quarkusFullMicroProfile\build-and-run.log and check these offending lines: 
Warning:  [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] You are using an older version of GraalVM or Mandrel : 23.0.4.1-deva441a627. Quarkus currently supports 23.1.0. Please upgrade to this version. ==> expected: <true> but was: <false>
	at org.graalvm.tests.integration.RuntimesSmokeTest.testRuntime(RuntimesSmokeTest.java:156)
	at org.graalvm.tests.integration.RuntimesSmokeTest.quarkusFullMicroProfile(RuntimesSmokeTest.java:200)

[INFO] 

Apparently a mismatch in the matrix, Q 999-SNAPSHOT vs. M 23.0.4.
The build went fine though, it's just the warning caught by the TS log audit.

@jerboaa
Copy link
Collaborator Author

jerboaa commented May 3, 2024

The three failing tests are: Mandrel IT (2x) - Linux and Windows and IT main.

Mandrel IT failures are log line and old quarkus version related.

Error:  Failures: 
Error:    DebugSymbolsTest.debugSymbolsQuarkus:306 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.DebugSymbolsTest/debugSymbolsQuarkus/build-and-run.log and check these offending lines: 
Warning:  [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] You are using an older version of GraalVM or Mandrel : 23.0.4.1-deva441a627. Quarkus currently supports 23.1.0. Please upgrade to this version. ==> expected: <true> but was: <false>
Error:    JFRTest.jfrPerfTest:181->jfrPerfTestRun:230 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.JFRTest/jfrPerfTest/build-and-run.log and check these offending lines: 
Warning:  [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] You are using an older version of GraalVM or Mandrel : 23.0.4.1-deva441a627. Quarkus currently supports 23.1.0. Please upgrade to this version. ==> expected: <true> but was: <false>
Error:    RuntimesSmokeTest.quarkusFullMicroProfile:200->testRuntime:156 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.RuntimesSmokeTest/quarkusFullMicroProfile/build-and-run.log and check these offending lines: 
Warning:  [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] You are using an older version of GraalVM or Mandrel : 23.0.4.1-deva441a627. Quarkus currently supports 23.1.0. Please upgrade to this version. ==> expected: <true> but was: <false>

IT main is Metrics related:

Error:    Run 1: ImageMetricsITCase.verifyImageMetrics:15 Multiple Failures (2 failures)
	org.opentest4j.AssertionFailedError: Expected analysis_results.types.reflection to be within range [8927 +- 3%] but was 9208 ==> expected: <true> but was: <false>
	org.opentest4j.AssertionFailedError: Expected analysis_results.fields.jni to be within range [70 +- 1%] but was 72 ==> expected: <true> but was: <false>
Error:    Run 2: ImageMetricsITCase.verifyImageMetrics:15 Multiple Failures (2 failures)
	org.opentest4j.AssertionFailedError: Expected analysis_results.types.reflection to be within range [8927 +- 3%] but was 9208 ==> expected: <true> but was: <false>
	org.opentest4j.AssertionFailedError: Expected analysis_results.fields.jni to be within range [70 +- 1%] but was 72 ==> expected: <true> but was: <false>
Error:    Run 3: ImageMetricsITCase.verifyImageMetrics:15 Multiple Failures (2 failures)
	org.opentest4j.AssertionFailedError: Expected analysis_results.types.reflection to be within range [8927 +- 3%] but was 9208 ==> expected: <true> but was: <false>
	org.opentest4j.AssertionFailedError: Expected analysis_results.fields.jni to be within range [70 +- 1%] but was 72 ==> expected: <true> but was: <false>
Error:    Run 4: ImageMetricsITCase.verifyImageMetrics:15 Multiple Failures (2 failures)
	org.opentest4j.AssertionFailedError: Expected analysis_results.types.reflection to be within range [8927 +- 3%] but was 9208 ==> expected: <true> but was: <false>
	org.opentest4j.AssertionFailedError: Expected analysis_results.fields.jni to be within range [70 +- 1%] but was 72 ==> expected: <true> but was: <false>

All of them are unrelated to this update.

@jerboaa
Copy link
Collaborator Author

jerboaa commented May 3, 2024

The build went fine though, it's just the warning caught by the TS log audit.

Yes. Anything lower than 23.1 for quarkus main will produce the warning.

@jerboaa jerboaa merged commit 2f1c3f2 into graalvm:mandrel/23.0 May 3, 2024
64 of 67 checks passed
@jerboaa jerboaa added this to the 23.0.4.0-Final milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants