Use maven local repository for GraalVM dependencies in gradle tests #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quarkus already instructs gradle to use the local maven repositories for io.quarkus.* artifacts. This sed command adds org.graal.* artifacts to the include pattern so that we can test locally built and installed GraalVM/Mandrel artifacts.
oracle-contributor-agreement
bot
added
the
OCA Verified
zakkak
force-pushed
the
2023-09-13-fix-gradle-testing
branch
from
0a64e89 to
953637e
Compare
|
I think there is no reason to restart the whole test suite for this. WDYT? |
zakkak
force-pushed
the
2023-09-13-fix-gradle-testing
branch
from
953637e to
ab7a21b
Compare
jerboaa
approved these changes
Sep 14, 2023
Yes, the only difference is that it wil not use the gradle cache but the maven cache (that's only for the org.graalvm.* deps), which I believe is acceptable for our testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quarkus already instructs gradle to use the local maven repositories for io.quarkus.* artifacts. This sed command adds org.graal.* artifacts to the include pattern so that we can test locally built and installed GraalVM/Mandrel artifacts.
Testing in progress in https://github.com/zakkak/mandrel/actions/runs/6171689706