Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Mandrel Windows build failing to produce native image agents, doesn't fail the build #636

Closed
jerboaa opened this issue Dec 15, 2023 · 2 comments
Labels
bug Something isn't working os/windows Windows specific testing CI and testing related issues and PRs

Comments

@jerboaa
Copy link
Collaborator

jerboaa commented Dec 15, 2023

Description

When we build Mandrel for Windows in CI the build doesn't fail if the native image agents fail to build. We need to correct this as it just makes triage more difficult. It starts to run tests - some of which are then bound to fail - while the actual mandrel build was incomplete. Example:

[...]
========================================================================================================================
GraalVM Native Image: Generating 'native-image-agent' (shared library)...
========================================================================================================================
For detailed information and explanations on the build output, visit:
https://github.com/oracle/graal/blob/master/docs/reference-manual/native-image/BuildOutput.md
------------------------------------------------------------------------------------------------------------------------

[1/8] Initializing...                                                                                    (0.0s @ 0.07GB)
Error: Could not find target method: private native com.oracle.svm.core.hub.Target_java_lang_PublicMethods_MethodList com.oracle.svm.core.hub.DynamicHub.getMethodsRecursive(java.lang.String,java.lang.Class[],boolean,boolean)
------------------------------------------------------------------------------------------------------------------------
                        0.2s (4.9% of total time) in 10 GCs | Peak RSS: 0.30GB | CPU load: 2.72
========================================================================================================================
Finished generating 'native-image-agent' in 3.1s.
Exception in thread "main" java.lang.RuntimeException: java.lang.RuntimeException: Failed, exit code: 1
	at OperatingSystem.exec(build.java:1827)
	at build.buildAgents(build.java:316)
	at build.main(build.java:259)
Caused by: java.lang.RuntimeException: Failed, exit code: 1
	at OperatingSystem.exec(build.java:1816)
	at build.buildAgents(build.java:316)
	at build.main(build.java:259)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at jdk.compiler/com.sun.tools.javac.launcher.Main.execute(Main.java:484)
	at jdk.compiler/com.sun.tools.javac.launcher.Main.run(Main.java:208)
	at jdk.compiler/com.sun.tools.javac.launcher.Main.main(Main.java:135)
native-image 22-beta 2024-03-19
OpenJDK Runtime Environment Mandrel-24.0.0-dev44554595 (build 22-beta+26-ea)
OpenJDK 64-Bit Server VM Mandrel-24.0.0-dev44554595 (build 22-beta+26-ea, mixed mode)

https://github.com/graalvm/mandrel/actions/runs/7216793492/job/19663590268#step:8:459

Then results in those strange test reports in Mandrel IT like here:
Karm/mandrel-integration-tests#207 (comment)

Expected Behaviour

Failing to produce the native image agents should fail the Mandrel build. I.e. Exit with error.

@jerboaa jerboaa added the bug Something isn't working label Dec 15, 2023
@zakkak zakkak added testing CI and testing related issues and PRs os/windows Windows specific labels Dec 15, 2023
@zakkak
Copy link
Collaborator

zakkak commented Dec 15, 2023

Duplicate of #555?

@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 15, 2023

yes. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working os/windows Windows specific testing CI and testing related issues and PRs
Projects
None yet
Development

No branches or pull requests

2 participants