Add gradle plugin to GraalPy demos #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
timfel
changed the title
timfel
force-pushed
the
tim/add-gradle-demos
branch
from
7a085ab
to
053c192
Compare
timfel
force-pushed
the
tim/add-gradle-demos
branch
from
053c192
to
e15dcde
Compare
timfel
changed the title
timfel
force-pushed
the
tim/add-gradle-demos
branch
from
d909fa2
to
292ec2b
Compare
|
I tried the JavaSE guide and it works fine except for one known issue (empty resources directory breaks the plugin). Some suggested changes are in https://github.com/graalvm/graal-languages-demos/compare/tim/add-gradle-demos...steve-s:graal-languages-demos:ss/gradle-demos-review?expand=1 |
steve-s
reviewed
Nov 5, 2024
steve-s
reviewed
Nov 5, 2024
steve-s
reviewed
Nov 5, 2024
|
I am done reviewing, I've pushed some suggestions/fixes to https://github.com/steve-s/graal-languages-demos/tree/ss/gradle-demos-review, feel free to cherry-pick and adapt as you see fit. (edit: pushed few more just now and I've really done :-)) |
steve-s
previously approved these changes
Nov 5, 2024
timfel
force-pushed
the
tim/add-gradle-demos
branch
from
292ec2b
to
a5eeaf4
Compare
steve-s
reviewed
Nov 6, 2024
steve-s
previously approved these changes
Nov 6, 2024
steve-s
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates some of our GraalPy guides and demos to show the gradle plugin. I didn't update those examples that do not use the maven plugin and a couple of examples that are simply concerned with a different set of packages. (graalpy-native-extensions-guide, graalpy-openai-starter, graalpy-spring-boot-pygal-charts, graalpy-micronaut-pygal-charts). Do you think those 4 should be updated as well?