This 'while' statement doesn't loop

[HelgeStenstrom]

XR3Player/src/main/java/com/goxr3plus/xr3player/services/xplayer/XPlayerPlayService.java

Lines 340 to 343 in 7d79f3b

	while (resultSet.next()) {
	exists = true;
	break;
	}

This 'while' statement doesn't loop. Does it work as intended? Can it be replaces with an if() structure instead?

[goxr3plus]

Yeah, it checks if the entry exists in the database that means if resultset has at least one element, i think it can be replaced with an if statement :)

[goxr3plus]

Good catch, you are doing amazing work i am impressed.

[goxr3plus]

@HelgeStenstrom Here is the solution :

https://javarevisited.blogspot.com/2016/10/how-to-check-if-resultset-is-empty-in-Java-JDBC.html

[goxr3plus]

@HelgeStenstrom How you can do that ? Sending me a link with the exact line of the file in github like you did ?

I don't know how to do it ... can you show me ?

[goxr3plus]

Oouuu i found out :) => https://help.github.com/en/articles/creating-a-permanent-link-to-a-code-snippet

[HelgeStenstrom]

Most of my findings are from IntelliJ’s code analysis.

[goxr3plus]

Would you like to solve this issue here is a solution?

https://javarevisited.blogspot.com/2016/10/how-to-check-if-resultset-is-empty-in-Java-JDBC.html

IT'S easy for me but in case you want to give it a try :)

[HelgeStenstrom]

I probably can’t do any coding until August. I leave this to you.