Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifiers): support multiple slack workspaces #67

Merged
merged 6 commits into from
Sep 12, 2023
Merged

feat(notifiers): support multiple slack workspaces #67

merged 6 commits into from
Sep 12, 2023

Commits on Sep 11, 2023

  1. feat: Search and Filter for ListAppeals and ListGrants (#62) 

    * feat: Add filter q, account_type for litAppeals and listGrants and added getTotalCount

* chore: added testing for total count

* chore: fix testing

* chore: fix test total

* chore: fix test mock appeal and grant

* chore: fix test mock user appeal and grant

* chore: fix test coverage

* chore: fix test coverage 2

* chore: fix test coverage 3

* chore: resolve comments

* test: resolve comments

* test: fix testing

---------

Co-authored-by: Lifosmin Simon <[email protected]>
    @lifosmin @bsushmith
    2 people authored and bsushmith committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    acb0a86 View commit details
    Browse the repository at this point in the history

  2. feat(notifiers): support multiple slack workspaces 

    - changes to configure multiple slack workspaces and corresponding bot tokens
- slack notifier will use email (other user attributes are difficult since for approvers we wouldn't have any additional details) for evaluating configured criteria and send notifications to corresponding slack workspace
- additional test cases
- maintains backward compatibility
    @bsushmith
    bsushmith committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5e263c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. refactor: use pointer for workspace in slack cache item

    @bsushmith
    bsushmith committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2a1113f View commit details
    Browse the repository at this point in the history

  2. refactor: use pointer for workspace in slack cache item

    @bsushmith
    bsushmith committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a54a6a3 View commit details
    Browse the repository at this point in the history

  3. chore: add test-short make directive

    @bsushmith
    bsushmith committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5d963e1 View commit details
    Browse the repository at this point in the history

  4. chore: add comments

    @bsushmith
    bsushmith committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5cc54fc View commit details
    Browse the repository at this point in the history