feat(notifiers): support multiple slack workspaces #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gadigeppa-J
previously requested changes
Sep 6, 2023
bsushmith
changed the title
rahmatrhd
requested changes
Sep 6, 2023
* feat: Add filter q, account_type for litAppeals and listGrants and added getTotalCount * chore: added testing for total count * chore: fix testing * chore: fix test total * chore: fix test mock appeal and grant * chore: fix test mock user appeal and grant * chore: fix test coverage * chore: fix test coverage 2 * chore: fix test coverage 3 * chore: resolve comments * test: resolve comments * test: fix testing --------- Co-authored-by: Lifosmin Simon <[email protected]>
bsushmith
force-pushed
the
slack-workspaces
branch
2 times, most recently
from
05322e0
to
a43e09c
Compare
- changes to configure multiple slack workspaces and corresponding bot tokens - slack notifier will use email (other user attributes are difficult since for approvers we wouldn't have any additional details) for evaluating configured criteria and send notifications to corresponding slack workspace - additional test cases - maintains backward compatibility
bsushmith
force-pushed
the
slack-workspaces
branch
from
a43e09c
to
5e263c9
Compare
rahmatrhd
reviewed
Sep 11, 2023
rahmatrhd
approved these changes
Sep 12, 2023
bsushmith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #39
Changes:
ToDo: