Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(resource): search query by resource name on appeals and approvals #186

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat(resource): search query by resource name on appeals and approvals #186

merged 1 commit into from
Nov 13, 2024

Conversation

idilhaq
Copy link

@idilhaq idilhaq commented Nov 8, 2024

https://go-jek.atlassian.net/browse/DFEXP-518
Supporting search query by resource.name

@rahmatrhd
Copy link
Member

@idilhaq shouldn't we need to make the same changes in ListGrants as well?

@idilhaq
Copy link
Author

idilhaq commented Nov 13, 2024

@idilhaq shouldn't we need to make the same changes in ListGrants as well?

@rahmatrhd it is already there on list grants and working fine on UI

@rahmatrhd rahmatrhd merged commit 44b1d22 into main Nov 13, 2024
8 of 9 checks passed
@rahmatrhd rahmatrhd deleted the search_by_resource_name branch November 13, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd rahmatrhd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idilhaq @rahmatrhd