Task solution Jakub Sepetowski #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d YAMl files Introduce 'Professions' enum (astronaut, doctor, engineer). Define 'CrewMember', 'JsonCrewMember', and 'YamlCrewMember' types. Implement file reading functions: - 'readJsonCrewMember' for JSON files. - 'readYamlCrewMember' for YAML files.
…on age, and sorts based on name
added dark theme mode
- Introduced a new data type for the received API information. - Moved the provider from the layout to _app.
… page, throwing a 404 error if it's invalid, implemented data retrieval from the API based on the provided page parameter, improved the layout, introduced a 404 error page
- Enhanced the overall layout for an improved user interface. - Added the functionality to dynamically display crew members in card format.
… h1 to crew members component
- Removed unnecessary enum Professions - Fixed data attributes for tests - Added tests for components: crewMembers, crewMember, and CrewInformationLoading
…oint validation for sent data.
Implemented pagination rendering check to determine whether rendering is necessary, and added corresponding tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, This is my solution for given task
As per the instructions, I created a method that allows merging json and yaml files into one sorted array. I am not sure if I understood the requirements correctly, but I encapsulated the entire logic of reading from files within the method from the library. In the endpoint, I only invoke it with the appropriate data. I retrieve data from the endpoint using React Query and handle exceptions. Additionally, I used Zod to check if the files from which I read data have the correct format to avoid unexpected errors.
For styling the application, I used the Shadcn library and implemented theme switching using Next Themes.
I also added tests to the application.
List of tools I used: