Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added utility functions should be internal #4

Open
shaunazzopardi opened this issue Oct 20, 2019 · 0 comments
Open

Added utility functions should be internal #4

shaunazzopardi opened this issue Oct 20, 2019 · 0 comments

Comments

@shaunazzopardi
Copy link
Collaborator

Current instrumentation creates variable modification functions as public. Instead these should be marked as internal. This is necessary from both a security issue (leaving them public allows anyone to modify the internal state), and from a gas-saving point of view (internal functions cost less to deploy than public functions).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shaunazzopardi