Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.6.1] unnecessary log entry in secure_channel sendAsyncWithTimeout #760

Open
lyimmi opened this issue Dec 18, 2024 · 1 comment · May be fixed by #761
Open

[v0.6.1] unnecessary log entry in secure_channel sendAsyncWithTimeout #760

lyimmi opened this issue Dec 18, 2024 · 1 comment · May be fixed by #761
Milestone
v0.6.2

Comments

@lyimmi
Copy link

lyimmi commented Dec 18, 2024

Hi everyone,

I tried the new version v0.6.1, everything look good, but unfortunately there is a log statement in secure_channel line:1036 - sendAsyncWithTimeout. It is not critical but it's littering in our central logging system, with every call.

If it is okay to remove I'm happy to make a pull request.

Thanks!
@danomagnum
Copy link
Contributor

Yeah, looks like that was a debugging log that got left in and could be removed without issue.

magiconair added a commit that referenced this issue Dec 20, 2024
@magiconair
uasc: remove debug log
d09bbde 
Fixes #760
@magiconair magiconair linked a pull request Dec 20, 2024 that will close this issue
Open
@magiconair magiconair added this to the v0.6.2 milestone Dec 20, 2024
magiconair added a commit that referenced this issue Dec 20, 2024
@magiconair
uasc: remove debug log
916d696 
Fixes #760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.2
Development

Successfully merging a pull request may close this issue.

uasc: remove debug log gopcua/opcua
3 participants
@magiconair @danomagnum @lyimmi