subscription: add ModifySubscription functionality #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kung-foo
reviewed
Apr 19, 2024
subscription.go
Outdated
| } | ||
|
|
||
| // update subscription parameters | ||
| s.params = ¶ms |
There was a problem hiding this comment.
These might need a lock. But it doesn't look like we have one in Subscription. There's this func (with a truly awful name):
Line 353 in 5aed8b4
There was a problem hiding this comment.
Do you suggest to create a new Subscription based on the current subscription and then invoke its recreate_NeedsSubMuxLock func to safely update these values?
Something like:
Suggested change
| s.params = ¶ms | |
| s.itemsMu.Lock() | |
| sub := &Subscription{ | |
| SubscriptionID: s.SubscriptionID, | |
| RevisedPublishingInterval: time.Duration(res.RevisedPublishingInterval) * time.Millisecond, | |
| RevisedLifetimeCount: res.RevisedLifetimeCount, | |
| RevisedMaxKeepAliveCount: res.RevisedMaxKeepAliveCount, | |
| Notifs: s.Notifs, | |
| items: s.items, | |
| params: ¶ms, | |
| nextSeq: s.nextSeq, | |
| c: s.c, | |
| } | |
| s.itemsMu.Unlock() | |
| err = sub.recreate_NeedsSubMuxLock(ctx) | |
| if err != nil { | |
| return nil, err | |
| } |
jackchenjc
force-pushed
the
issue-713
branch
2 times, most recently
from
85acce4 to
47e6bf5
Compare
closes gopcua#713 Signed-off-by: Jack Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #713
Simply add the following code to
examples/subscribe/subscribe.gocan test this new feature