Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): add GoogleMaps.h import in the readme file, required for GMS to work. #374

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stealkiller06
Copy link

@stealkiller06 stealkiller06 commented Dec 5, 2024

GMSServices won't work if we don't import GoogleMaps.h

  • Tests pass
  • Appropriate changes to documentation are included in the PR

GMSServices won't work if we don't import GoogleMaps.h
Copy link

google-cla bot commented Dec 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution!

Small nit about extra lines.

Missing CLA from you as well. After this is cleared we can merge this change.

https://github.com/googlemaps/react-native-navigation-sdk/pull/374/checks?check_run_id=33982682422

README.md Outdated
@@ -119,6 +121,8 @@ To set up, specify your API key in the application delegate `ios/Runner/AppDeleg

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these extra lines are added here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed these extra lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants