test: integration tests #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokerttu
reviewed
Dec 2, 2024
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Run unit tests | ||
| run: yarn test --maxWorkers=2 --coverage | ||
| # test: |
There was a problem hiding this comment.
NOTE: This will be enabled in separate PR
jokerttu
requested changes
Dec 3, 2024
There was a problem hiding this comment.
@illuminati1911
Looks already good.
Would like to have way to run the tests against release build. If current version is kept, the contribution.md document must tell that metro must be running when running tests.
See examples at:
https://github.com/wix/Detox/blob/e3393c7f62a68188808b6054b97608a84ec43cd1/examples/demo-react-native/README.md?plain=1#L37-L81
Also some tests (at least on iOS) fail quite ofter... this can be improved separately, but if these can be made more stable in this PR the better.
jokerttu
force-pushed
the
test/integration-tests
branch
from
aafea99 to
c713881
Compare
jokerttu
approved these changes
Dec 5, 2024
|
@ArturoSalazarB16 waiting final check from you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests to the project. For the tests detox is used along with example app implementation.