Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is onNavigationViewControllerCreated required? #356

Open
ziga-hvalec opened this issue Nov 21, 2024 · 2 comments
Open

Why is onNavigationViewControllerCreated required? #356

ziga-hvalec opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. type: question Request for information or clarification. Not an issue.

Comments

@ziga-hvalec
Copy link
Collaborator

ziga-hvalec commented Nov 21, 2024

We just want to use a map to show some markers. We're not using navigation on that screen.

When doing something like, typescript complains.

<NavigationView
  mapViewCallbacks={mapViewCallbacks}
  onMapViewControllerCreated={setMapViewController}
  // onNavigationViewControllerCreated={() => {}}
/>

For now we have an empty controller 🤷

@ziga-hvalec ziga-hvalec added triage me I really want to be triaged. type: question Request for information or clarification. Not an issue. labels Nov 21, 2024
@jokerttu
Copy link
Contributor

Yes, this should not be mandatory; marking this as feature-request
You could also use MapView instead of NavigationView if navigation should not be visible on the view:
https://github.com/googlemaps/react-native-navigation-sdk?tab=readme-ov-file#add-a-map-view

@jokerttu jokerttu added feature request New feature or request type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. feature request New feature or request labels Nov 21, 2024
@jokerttu jokerttu changed the title Why is onNavigationViewControllerCreated reqired? Why is onNavigationViewControllerCreated required? Nov 22, 2024
@ziga-hvalec
Copy link
Collaborator Author

I was not aware this was now available.
I was told previously to just use navigation View without navigation :D
I'll try Map View instad. In this case you can ignore this. since Navigation view should include this parameter.
You can close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

2 participants