feat: add map padding #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokerttu
reviewed
Dec 9, 2024
| @@ -188,6 +188,15 @@ export const useNavigationAuto = (): { | |||
| moveCamera: (cameraPosition: CameraPosition) => { | |||
| return NavAutoModule.moveCamera(cameraPosition); | |||
| }, | |||
|
|
|||
| setPadding: ( | |||
There was a problem hiding this comment.
Not sure about this order.
- iOS UIEdgeInsetsMake has currently implemented order: top, left, bottom, right.
- In Android API the order is: left, top, right, bottom.
- Using CSS (react users could be familiar with this) the order would be: top | right | bottom | left
Should we go with css order, or with Android (or keep the current iOS ordering).
jokerttu
reviewed
Dec 9, 2024
There was a problem hiding this comment.
LGTM
And seems to work on both, Android and iOS.
On android the bottom padding does not move the re-center button like on iOS, but this is something that differs between Android and iOS SDKs.
Added one comment, waiting resolution from @ArturoSalazarB16 and @caio1985
Yeah, this got me confused for a moment. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292
This PR adds map padding support to both regular map view as well as Android auto/Carplay map views.