Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

None of the navigationCallbacks seems to trigger after upgrading to 0.6.0 from 0.3.4 #274

Open
ziga-hvalec opened this issue Sep 26, 2024 · 4 comments
Open

None of the navigationCallbacks seems to trigger after upgrading to 0.6.0 from 0.3.4 #274

ziga-hvalec opened this issue Sep 26, 2024 · 4 comments
Assignees
@jokerttu
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ziga-hvalec
Copy link
Collaborator

Without any code changes execpt removing width and height none of the navigationCallbacks trigger anymore. Not even navigation ready.
I first upgraded to 0.4.3 and noticed that onRemainingTimeOrDistanceChanged no longer triggers even when ETA or distance on screen change. #273

Based on changelogs I don't see any other braking changes that could cause this.
@ziga-hvalec ziga-hvalec added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 26, 2024
@ziga-hvalec
Copy link
Collaborator Author

Seems to happen if i make any changes in the code without full app restart.

@jokerttu jokerttu added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Sep 26, 2024
@illuminati1911
Copy link
Contributor

@ziga-hvalec Thanks for reporting the issue. We'll investigate this.

@ziga-hvalec
Copy link
Collaborator Author

Any update on this?

@jokerttu
Copy link
Contributor

@ziga-hvalec not yet, we will change the internal communication layer a bit while supporting the "new architecture" and investigate this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jokerttu jokerttu

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jokerttu @illuminati1911 @ziga-hvalec