Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct exports of the module #909

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trygve-lie
Copy link

@trygve-lie trygve-lie commented Aug 12, 2024

Correct exports of the module for better module loading compatibility with node.js.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #908 🦕

Copy link

google-cla bot commented Aug 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@trygve-lie trygve-lie changed the title Corrects exports of the module Correct exports of the module Aug 13, 2024
@trygve-lie trygve-lie force-pushed the export branch 3 times, most recently from 137cf93 to 17903a6 Compare November 6, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct exports of the module for better module loading compatibility with node.js
1 participant