Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document correlation to @googlemaps/react-wrapper library #153

Open
tobiasbueschel opened this issue Nov 18, 2023 · 2 comments
Open

Document correlation to @googlemaps/react-wrapper library #153

tobiasbueschel opened this issue Nov 18, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation type: question Request for information or clarification. Not an issue.

Comments

@tobiasbueschel
Copy link

Thanks for this library 🙏 great to have an official Google library that supports React components too. However, for the React example here in the repo are there also wrapper components for gmp-map and gmp-advanced-marker or should one mix this library with https://github.com/googlemaps/react-wrapper?

@tobiasbueschel tobiasbueschel added triage me I really want to be triaged. type: question Request for information or clarification. Not an issue. labels Nov 18, 2023
@wangela
Copy link
Member

wangela commented Nov 18, 2023

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@tobiasbueschel Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@awmack awmack added documentation Improvements or additions to documentation and removed triage me I really want to be triaged. labels Nov 20, 2023
@awmack
Copy link
Contributor

awmack commented Nov 20, 2023

Thanks for the comment! As you notice, in the React example we use <gmp-map> and <gmp-advanced-marker> without any wrappers. These web components come directly from the Maps JS API, which is in turn loaded/configured from the API Loader component in the current library -- nothing else required to use them. See this line.

https://github.com/googlemaps/react-wrapper is a single-purpose library for loading the Maps JS API in the context of a React app. This should work if you mix it with the Extended Component Library, but I'd recommend sticking with the API Loader component instead: it's designed to work cross-framework (i.e. not specific to React) and is what we test against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants