-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaperglot reporting missing punctuation? #66
Comments
Shaperglot just checks base characters. |
I vaguely remember having talked about this a while back. Should it not maybe check everything except auxiliary? |
Could the characters sets to check maybe be parameters of the For instance, the GF_Latin_African glyphset even includes auxiliary characters, so ideally those would be checked as well. cc @moyogo If shaperglot is the wrong place for this, I would instigate a new or revised fontbakery check, but it would really just duplicate functionality already existing in shaperglot. |
If a language uses The gflanguages punctuation data should be doublechecked but, at least for Latin, there’s a common set, plus or minus the variation of ‘ ’ “ ” « », or ¿ ¡. Auxiliary is not well defined and gflanguages inherited the contradictions and inconsistencies from the sources it copied data from. The African Latin auxiliary data was narrowed down to historical use that may still occur. Shaperglot should likely only check shaping of auxiliary chars if present, and maybe warn if not missing. |
In this case, wouldn't the identified inconsistencies impact the results? For instance, some languages do not include uppercase (or accented) letters in the base characters. e.g. Could this lead to misleading results?
|
I was under the impression that shaperglot would also report on characters missing in a font.
The attached font is missing
»
, yet neither Fontbakery’sshape_languages
check nor an explicitshaperglot check Maname-Regular.ttf fr_Latn
complain about the missing glyph.Maname-Regular.ttf.zip
The text was updated successfully, but these errors were encountered: