Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright notice check has incorrect assumption about date #62

Open
davelab6 opened this issue Jun 29, 2020 · 1 comment
Open

Copyright notice check has incorrect assumption about date #62

davelab6 opened this issue Jun 29, 2020 · 1 comment
Assignees

Comments

@davelab6
Copy link
Member

self.assertIsNotNone(
copyright_search,
('Copyright string is incorrect.\n\n'
'It must contain or be:\n'
'Copyright %s The %s Project Authors (%s)\n\n'
'If the family has a RFN:\n'
'Copyright %s The %s Project Authors (%s), '
'with Reserved Font Name "%s".') % (
datetime.now().year,
font.familyName,
repo_git_url,
datetime.now().year,
font.familyName,
repo_git_url,
font.familyName,
)
)

This check is wrong, the copyright date should be the earliest date that the project started, not the current date. There is likely no way to check that date programmatically, so a regex that checks for 4 digits making the year is sufficient (likely started 19 or 20 :)

@m4rc1e
Copy link
Contributor

m4rc1e commented Jun 29, 2020

Good catch.

I'll be revisiting this repo in the next few weeks so it follows our new spec. I want the fix script to be able to output a flawless VF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants