Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright string check / OFL copyright mismatch error #29

Open
noponies opened this issue Jul 30, 2018 · 3 comments
Open

Copyright string check / OFL copyright mismatch error #29

noponies opened this issue Jul 30, 2018 · 3 comments

Comments

@noponies
Copy link

noponies commented Jul 30, 2018

I get the following error when running QA from Glyphs (Version 2.5.1 (1141)) "OFL.txt and font copyright do not match." when as far as I can tell, they are functionally the same. Have checked for hidden characters etc; and not found anything amiss. Copyright is on first line of OFL.txt.

Strings in question below;

OFL copyright: Copyright 2018 The Turret Road Project Authors (https://github.com/noponies/turret-road)
Font copyright: Copyright 2018 The Turret Road Project Authors (https://github.com/noponies/turret-road)

@m4rc1e
Copy link
Contributor

m4rc1e commented Aug 1, 2018

Thanks @noponies. I'll look into this!

@m4rc1e
Copy link
Contributor

m4rc1e commented Aug 1, 2018

@noponies your OFL.txt line endings are for Windows, http://www.cs.toronto.edu/~krueger/csc209h/tut/line-endings.html. I see we use Unix line endings for the OFLs in https://github.com/google/fonts/tree/master/ofl

I'm keeping this open for the time being.

@noponies
Copy link
Author

noponies commented Aug 1, 2018

Thanks for the reply.

I opened up the OFL.txt file and converted to Unix/MacOS line endings, re ran the QA test suite and it passed.

I originally sourced the OFT.txt file from SIL and re checking a fresh download of that shows it has Windows line endings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants