Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile times #1249

Open
nicoburns opened this issue Nov 18, 2024 · 1 comment
Open

Compile times #1249

nicoburns opened this issue Nov 18, 2024 · 1 comment

Comments

@nicoburns
Copy link

nicoburns commented Nov 18, 2024

I've just been looking into compile times for Blitz. And read-fonts (16.14s) and skrifa (9.61s) both stand out in the profile. This is for a release build:

Image

This mostly gets hidden by parallel compilation (the non-codegen times are not nearly so bad). And perhaps this is the only way to get the runtime performance and type safety of this crate. But nevertheless I though this should be tracked, and considered when implementing changes to these crates.

(note also the compile time for ttf-parser at the bottom of the screenshot - only 5.5s!)

@cmyr
Copy link
Member

cmyr commented Nov 19, 2024

thanks! the codegen-based approach to the design of read-fonts does mean that we often end up compiling a lot of code, so naively I imagine that is most of what's going on here (and a quick look with -Ztime-passes doesn't show anything egregious). There are some design choices we could reconsider if this ends up feeling serious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants