Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COLRv1 bounds computation traverses unnecessary branches #1160

Open
drott opened this issue Sep 23, 2024 · 0 comments
Open

COLRv1 bounds computation traverses unnecessary branches #1160

drott opened this issue Sep 23, 2024 · 0 comments

Comments

@drott
Copy link
Contributor

drott commented Sep 23, 2024

In COLRv1 bounds computation, clients of Skrifa would usually use a call to ColorGlyph::paint with a ColorPainter that tracks the bounds of the pushed operations.

However, branches / parts of the glyph below the first clip level do not need to be tracked further, as the bounds cannot grow after an initial clip.

Clients can track this and ignore operations after the initial clip level.

But to address this inefficiency and not issue the extra calls, we could for example add a mode for the ColorPainter object so it can be asked whether it is in bounds mode - or a switch to the paint()method, or perform bounds computation in Skrifa (but this might be tricky due to handling client side transforms?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant