Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fonts use foundry "pyrs" instead of "GOOG" #23

Open
ambihelical opened this issue Sep 27, 2020 · 2 comments
Open

Some fonts use foundry "pyrs" instead of "GOOG" #23

ambihelical opened this issue Sep 27, 2020 · 2 comments

Comments

@ambihelical
Copy link

ambihelical commented Sep 27, 2020

I think this is causing an app I use (emacs) to be unable to use italic. I don't know much about fonts, so I could be way off on this. I'm sure it could be argued that it should not matter, and emacs is buggy, but this looks like a mistake to me, and maybe it will fix the issue.

▶ rg pyrs
------------------------- Sun Sep 27 16:02:35 PDT 2020 -------------------------------
RobotoMono-BoldItalic.ufo/fontinfo.plist
118:    <string>pyrs</string>

RobotoMono-ThinItalic.ufo/fontinfo.plist
118:    <string>pyrs</string>

RobotoMono-Italic.ufo/fontinfo.plist
118:    <string>pyrs</string>
▶ rg GOOG
------------------------- Sun Sep 27 16:02:40 PDT 2020 -------------------------------
RobotoMono-Bold.ufo/fontinfo.plist
149:    <string>GOOG</string>

RobotoMono-Regular.ufo/fontinfo.plist
149:    <string>GOOG</string>

RobotoMono-Thin.ufo/fontinfo.plist
149:    <string>GOOG</string>
@ambihelical
Copy link
Author

UPDATE: after using a binary editor to change pyrs to GOOG in the offending ttf files, this did resolve the issue with emacs and Roboto-Mono. It would be great if there was an official release with this change.

ambihelical added a commit to ambihelical/dotfiles that referenced this issue Sep 28, 2020
Note that this font has a bug in it which causes italic to not
function in emacs. This has been reported to the repo, fortunately
this is easily worked around using a binary editor.

googlefonts/RobotoMono#23
ambihelical added a commit to ambihelical/dotfiles that referenced this issue Oct 10, 2020
* add theme
* update moody
* remove zenburn-hc specific changes
* Use Roboto Mono for hum font

On Roboto Mono:

Note that this font has a bug in it which causes italic to not
function in emacs. This has been reported to the repo, fortunately
this is easily worked around using a binary editor.

googlefonts/RobotoMono#23
@petergardfjall
Copy link

I saw the exact same behavior: Emacs failing to render/recognize the italic variants of the font due to the inconsistent vendor ID. I opened a PR: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants