fix(java-yoshi): match full artifact id when updating versions (#2398)

* fix: match full artifact id when updating versions * add unit tests * lint * fix unit test * lint * restore package * restore package * add unit test
googleapis · Oct 8, 2024 · e062dc1 · e062dc1
1 parent 15c75a9
commit e062dc1
Show file tree

Hide file tree

Showing 5 changed files with 60 additions and 2 deletions.
diff --git a/__snapshots__/version-manifest.js b/__snapshots__/version-manifest.js
@@ -1,3 +1,19 @@
+exports['VersionManifest updateContent updates versions.txt with an artifact id is another ones suffix with snapshot 1'] = `
+# Format:
+# module:released-version:current-version
+
+google-cloud-admin:2.3.4:2.3.4
+admin:3.4.5:3.4.5
+`
+
+exports['VersionManifest updateContent updates versions.txt with an artifact id is another ones suffix without snapshot 1'] = `
+# Format:
+# module:released-version:current-version
+
+google-cloud-admin:2.3.6:2.3.6
+admin:3.4.3:3.4.3
+`
+
 exports['VersionManifest updateContent updates versions.txt with snapshot released version 1'] = `
 # Format:
 # module:released-version:current-version

diff --git a/src/updaters/java/versions-manifest.ts b/src/updaters/java/versions-manifest.ts
@@ -52,14 +52,14 @@ export class VersionsManifest extends JavaUpdate {
       if (version.includes('SNAPSHOT')) {
         newLines.push(
           line.replace(
-            new RegExp(`${packageName}:(.*):(.*)`, 'g'),
+            new RegExp(`^${packageName}:(.*):(.*)`, 'g'),
             `${packageName}:$1:${version}`
           )
         );
       } else {
         newLines.push(
           line.replace(
-            new RegExp(`${packageName}:(.*):(.*)`, 'g'),
+            new RegExp(`^${packageName}:(.*):(.*)`, 'g'),
             `${packageName}:${version}:${version}`
           )
         );

diff --git a/test/updaters/fixtures/versions-suffix-with-snapshot.txt b/test/updaters/fixtures/versions-suffix-with-snapshot.txt
@@ -0,0 +1,5 @@
+# Format:
+# module:released-version:current-version
+
+google-cloud-admin:2.3.5:2.3.5
+admin:3.4.2:3.4.2
diff --git a/test/updaters/fixtures/versions-suffix-without-snapshot.txt b/test/updaters/fixtures/versions-suffix-without-snapshot.txt
@@ -0,0 +1,5 @@
+# Format:
+# module:released-version:current-version
+
+google-cloud-admin:2.3.0:2.3.1-SNAPSHOT
+admin:3.4.0:3.4.1-SNAPSHOT
diff --git a/test/updaters/version-manifest.ts b/test/updaters/version-manifest.ts
@@ -82,5 +82,37 @@ describe('VersionManifest', () => {
       const newContent = javaAuthVersions.updateContent(oldContent);
       snapshot(newContent);
     });
+
+    it('updates versions.txt with an artifact id is another ones suffix with snapshot', async () => {
+      const oldContent = readFileSync(
+        resolve(fixturesPath, './versions-suffix-with-snapshot.txt'),
+        'utf8'
+      ).replace(/\r\n/g, '\n');
+      const versions = new Map<string, Version>();
+      versions.set('google-cloud-admin', Version.parse('2.3.4'));
+      versions.set('admin', Version.parse('3.4.5'));
+      const javaAuthVersions = new VersionsManifest({
+        versionsMap: versions,
+        version: Version.parse('1.2.3'),
+      });
+      const newContent = javaAuthVersions.updateContent(oldContent);
+      snapshot(newContent);
+    });
+
+    it('updates versions.txt with an artifact id is another ones suffix without snapshot', async () => {
+      const oldContent = readFileSync(
+        resolve(fixturesPath, './versions-suffix-without-snapshot.txt'),
+        'utf8'
+      ).replace(/\r\n/g, '\n');
+      const versions = new Map<string, Version>();
+      versions.set('google-cloud-admin', Version.parse('2.3.6'));
+      versions.set('admin', Version.parse('3.4.3'));
+      const javaAuthVersions = new VersionsManifest({
+        versionsMap: versions,
+        version: Version.parse('1.2.3'),
+      });
+      const newContent = javaAuthVersions.updateContent(oldContent);
+      snapshot(newContent);
+    });
   });
 });