From 454c1d7364245c4db87b8d5fb4dda6f09850301a Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Thu, 7 Sep 2023 10:29:15 -0700 Subject: [PATCH] ci: set NODE_OPTIONS for node 18 --- .github/workflows/ci.yaml | 3 +++ package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index f93e39dfa..9e8bd06fd 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -15,6 +15,9 @@ jobs: - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} + - name: Override NODE options for the most recent version + if: matrix.node == '18' + run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $GITHUB_ENV - run: node --version # The first installation step ensures that all of our production # dependencies work on the given Node.js version, this helps us find diff --git a/package.json b/package.json index 868591feb..afee9b0d9 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "main": "./build/src/index.js", "bin": "./build/src/bin/release-please.js", "scripts": { - "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test", + "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test", "docs": "echo add docs tests", "test:snap": "SNAPSHOT_UPDATE=1 LC_ALL=en npm test", "clean": "gts clean",