Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating devDependencies in monorepo triggers release #1045

Open
mdjermanovic opened this issue Oct 18, 2024 · 0 comments
Open

Updating devDependencies in monorepo triggers release #1045

mdjermanovic opened this issue Oct 18, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mdjermanovic
Copy link

Environment details

  • Programming language: JS
  • OS: ubuntu-latest
  • Language runtime version: I'm not sure what this refers to.
  • Package version: v4

Steps to reproduce

Here's a live example: eslint/rewrite#124

Since the last release, we had a releasable change in the @eslint/core package only.

In the same monorepo, @eslint/plugin-kit and @eslint/compat packages have @eslint/core in devDependencies (not dependencies).

The behavior I'd expect is that the release PR updates devDependencies in these two packages, but does not update the version field, because updating devDependencies should not be a reason to bump the version and release the package.

The actual behavior is that the release PR updates devDependencies in these two packages, and updates the version field. Merging the PR will likely release these two packages too, which is unnecessary as there were no releasable changes in them.

@mdjermanovic mdjermanovic added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant