Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): support bucket restore in soft delete phase 2 #13894

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(storage): support bucket restore in soft delete phase 2 #13894

wants to merge 6 commits into from

Conversation

mahendra-google
Copy link

Feature request includes the following:-

  1. Get Bucket Generation
  2. Get a Soft Deleted Bucket (Also soft-delete time and hard-delete time)
  3. List Soft Deleted Buckets
  4. Restore a Soft Deleted Bucket

@mahendra-google mahendra-google requested review from a team as code owners November 28, 2024 12:39
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 28, 2024
jskeet
jskeet reviewed Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a full code review by any means, but I'm hoping that this little bit will reduce the number of iterations required after Amanda is back from Thanksgiving.

Directory.Packages.props Outdated
@@ -1,5 +1,6 @@
<Project>
<ItemGroup>
<PackageVersion Include="Google.Apis.Storage.v1" Version="1.68.0.3604" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change, edit apis.json to change the dependency version (in the block for Google.Cloud.Storage.V1) and run generateprojects.sh to regenerate the project file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will revert this change and will edit apis.json with the same dependency version for (Google.Cloud.Storage.V1).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jskeet I have reverted my changes from Directory.Packages.props and updated Google.Apis.Storage.v1 version (1.68.0.3604) in apis.json file and after running generateprojects.sh , Google.Apis.Storage.v1 project file got automatically updated.

@mahendra-google
Copy link
Author

This is not a full code review by any means, but I'm hoping that this little bit will reduce the number of iterations required after Amanda is back from Thanksgiving.

Ok

@mahendra-google
revert changes from Directory.Packages.props , changes in dependency …
842d4df 
…version for Google.Cloud.Storage.V1 in apis.json
@jskeet
Copy link
Collaborator

jskeet commented Nov 29, 2024

Unassigning myself from review - I'm on vacation until Tuesday. (I expect Amanda will review before then.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet Awaiting requested review from jskeet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahendra-google @jskeet