Skip to content
This repository has been archived by the owner on Mar 1, 2022. It is now read-only.

Commit

Permalink
fix: os.path.commonpath needs list in python 3.5- (#553)
Browse files Browse the repository at this point in the history
`os.path.commonpath` accepts `set` in 3.6+ but for older versions it still needs to be a `list`.
  • Loading branch information
alexander-fenster authored Jan 17, 2019
1 parent f7e2899 commit 5bcb888
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion artman/tasks/python_grpc_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,5 +255,5 @@ def _get_proto_path(self, grpc_path):
# the whole filename, not the directory name.
return os.path.dirname(filenames.pop())
else:
return os.path.commonpath(filenames)
return os.path.commonpath(list(filenames))

0 comments on commit 5bcb888

Please sign in to comment.