Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries with no results return a null array #283

Open
cryy opened this issue Oct 15, 2024 · 0 comments
Open

Queries with no results return a null array #283

cryy opened this issue Oct 15, 2024 · 0 comments

Comments

@cryy
Copy link

cryy commented Oct 15, 2024

Hello!

This library allows you to query via StatementBuilder. When you run a query that returns no results, the XYPage#getResults() returns null. On my side, this has only been confirmed to be true with InventoryServiceInterface#getAdUnitsByStatement(), however it would be right to assume it is true for other query implementations as well.

Returning null arrays is an anti-pattern. Can this be fixed to return empty arrays instead? This has already been mentioned in #214.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant