How is continuous_pickup/continuous_drop_off forbid language interpreted? Should it be adjusted to explicitly allow values of 1?

[westontrillium]

Introduce yourself

Weston Shippy, Trillium

Ask a question

Currently the restriction reads: "Forbidden if stop_times.start_pickup_drop_off_window or stop_times.end_pickup_drop_off_window are defined..."

Does this mean any presence of this field is forbidden if the above conditions are met, regardless of the specific value?

I can't think of why we would want to forbid an explicit value of "not available" when that's implicitly what is being stated by this restriction. Should it be changed to match the spirit of stop_times.pickup_type/drop_off_type? Like so:

"Any continuous_pickup/continuous_drop_off value other than 1 or empty is forbidden if start_pickup_drop_off_window or end_pickup_drop_off_window are defined..."

[gcamp]

Your interpretation is what I assume was the original intent. I think defined was incorrectly used as "defined to non-default value"

[tzujenchanmbd]

Thanks for catching this @westontrillium

Agree that value 1 should be allowed here.