Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the whitespace character in the sed regular expression that o… #293

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

clydegerber
Copy link
Contributor

…perates on ctags output with a space and replace 'echo' with 'printf' to write out the coverage report. Sort output files with a stable, case-insensitive sort.

…perates on ctags output with a space and replace 'echo' with 'printf' to write out the coverage report. Sort output files with a stable, case-insensitive sort.
@clydegerber
Copy link
Contributor Author

These changes were required to get 'make cov' to produce reasonable output on a MacOS. Open to any suggestions - I think that replacing the '\s' with a ' ' in the regular expression should be safe, as it is operating on ctags output. The MacOS sed apparently doesn't recognize '\s' in a sed reg ex and was treating it as a literal. 'echo' was introducing some additional spaces which I've eliminated by replacing it with 'printf'. I don't understand why the files in which some functions were re-ordered were as they were before unless there was some previous manual editing(?) - the '_' character doesn't look like it was sorted consistently previously.

@filmil
Copy link
Member

filmil commented Oct 30, 2023

Thanks for the contribution.

@filmil filmil merged commit f6db408 into google:main Oct 30, 2023
15 checks passed
@clydegerber clydegerber deleted the mac_showprogress branch October 30, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants