Implement uformattable.h
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the changes needed to register the new `rust_icu_formattable` crate. Actual implementation will be in followup commits. Issue google#140
Almost all functions are implemented. It seems that uformattable does not, in fact, initialize formattables, but instead has a bunch of getter methods that allow us to inspect existing formattables. Closes google#140.
kpozin
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains low-level functions for the formattables.
Almost all functions are implemented. For example,
get_objectis not, sinceI don't know what we'd do with an object.
It seems that uformattable does
not, in fact, initialize formattables, but instead has a bunch of getter
methods that allow us to inspect existing formattables.
This limits testability, so tests will need to come from testing the users of
this functionality.
Closes #140.