Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement uformattable.h #140

Closed
filmil opened this issue Jun 23, 2020 · 0 comments · Fixed by #142
Closed

Implement uformattable.h #140

filmil opened this issue Jun 23, 2020 · 0 comments · Fixed by #142
Assignees
@filmil
Labels
enhancement New feature or request

Comments

@filmil
Copy link
Member

filmil commented Jun 23, 2020

The functions in the uformattable.h header are needed for the number formatting in issue #137.
@filmil filmil self-assigned this Jun 23, 2020
filmil added a commit to filmil/rust_icu that referenced this issue Jun 23, 2020
@filmil
Adds definitions needed for uformattable.h.
3cb0017 
This adds the changes needed to register the new `rust_icu_formattable`
crate.  Actual implementation will be in followup commits.

Issue google#140
filmil added a commit to filmil/rust_icu that referenced this issue Jun 23, 2020
@filmil
Implements uformattable.h
f30a565 
Almost all functions are implemented.  It seems that uformattable does
not, in fact, initialize formattables, but instead has a bunch of getter
methods that allow us to inspect existing formattables.

Closes google#140.
@filmil filmil mentioned this issue Jun 23, 2020
Merged
filmil added a commit that referenced this issue Jun 23, 2020
@filmil
Adds definitions needed for uformattable.h.
41c86fa 
This adds the changes needed to register the new `rust_icu_formattable`
crate.  Actual implementation will be in followup commits.

Issue #140
filmil added a commit that referenced this issue Jun 23, 2020
@filmil
Implements uformattable.h
6c4eea0 
Almost all functions are implemented.  It seems that uformattable does
not, in fact, initialize formattables, but instead has a bunch of getter
methods that allow us to inspect existing formattables.

Closes #140.
@filmil filmil added the enhancement New feature or request label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filmil filmil

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement uformattable.h filmil/rust_icu
1 participant
@filmil