Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EncodeToInterface and DecodeToInterface methods should be public #70

Open
DominikDeak opened this issue Sep 2, 2016 · 0 comments
Open

Comments

@DominikDeak
Copy link

DominikDeak commented Sep 2, 2016

The VCDiffEncoder::EncodeToInterface method and the corresponding VCDiffDecoder::DecodeToInterface are currently private in their respective classes.

I don't see the rationale behind this, because the streaming versions of the encoder/decoder classes publicly expose methods that work with OutputStringInterface derived objects.

The aforementioned methods should be made public, because working with OutputStringInterface offers more flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant