Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bazel version 8+ #662

Open
drinckes opened this issue Dec 23, 2024 · 3 comments
Open

Update to Bazel version 8+ #662

drinckes opened this issue Dec 23, 2024 · 3 comments

Comments

@drinckes
Copy link
Contributor

This is a placeholder issue.

Once Bazel JS closure rules (https://github.com/bazelbuild/rules_closure) is available as a Bazel module, it should be moved from the WORSKSPACE file to MODULE.bazel, and the Bazel version specified in .bazeliskrc can be updated to whatever is the current version.

Until then, we can't go past Bazel version 7.4.1 (since later versions do not use the WORKSPACE file to load dependencies).

@fulldecent
Copy link
Contributor

Related upstream issue for tracking: bazelbuild/rules_closure#616

@bcsgh
Copy link

bcsgh commented Dec 24, 2024

FWIW: Bazel 8.0.0 has the --noenable_bzlmod --enable_workspace flags, but "WORKSPACE support will be removed in Bazel 9 (late 2025)"

@drinckes
Copy link
Contributor Author

drinckes commented Dec 24, 2024

Thanks @fulldecent , @bcsgh - I got the recommendation for 7.4.1 from @gkdn, one of the rules_closure committers.

After spending about two days to move it to 8.0.0 then back to 7.4.1 and get it all working I'm ok with leaving it there for now. 🐢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants