You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All crawlers do not need scan_config for their crawling mechanism. Hence it's redundant to pass the scan config into every crawler and needs refinement.
Hi maintainers, I am starting to work on this issue. I plan to make a new staticmethod inside ICrawlerbase class which is base class of every crawler class.
The method will set if the crawler needs a config or not and then we can call it accordingly to know if we need to send a config or not. Currently, as to what I have seen only StorageBucketsCrawler uses the config file, so only it will return true when asked if cofig needed.
All crawlers do not need
scan_config
for their crawling mechanism. Hence it's redundant to pass the scan config into every crawler and needs refinement.Ref:
gcp_scanner/src/gcp_scanner/scanner.py
Line 234 in 27fd173
The text was updated successfully, but these errors were encountered: