Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload latest to conan repository #93

Open
Rwardc opened this issue May 29, 2019 · 6 comments
Open

Upload latest to conan repository #93

Rwardc opened this issue May 29, 2019 · 6 comments

Comments

@Rwardc
Copy link

Rwardc commented May 29, 2019

Certain fixes, like those referenced by #89, have not yet been uploaded to JFrog.

@poletti-marco
Copy link
Contributor

I know I need to do this (sorry) but I've been very busy and I currently don't have access to a Windows system to do this from.
I should get access again within ~2w.
Sorry for the inconvenience.

If you'd like to do this sooner and if there's some way for me to delegate access to you for this, I'd be happy to do so.

@Rwardc
Copy link
Author

Rwardc commented May 30, 2019

We've addressed the problem by checking out the source and doing a conan create locally on our build machine. If and when you update the JFrog repo, we'll switch back to grabbing it from there.

Do you need the Windows system to run your regression tests?

@poletti-marco
Copy link
Contributor

Do you need the Windows system to run your regression tests?

Regression tests run on Appveyor and are still working.

I was planning to use that Windows system to create/upload the windows binaries.
But maybe you don't need that?

I now realized I could run "conan create" from my Linux system, so I've done that now if it helps.

@Rwardc
Copy link
Author

Rwardc commented May 30, 2019

Perfect. Yes, we just needed the updated conanfile.py. As long as that's up-to-date, then everything should be working fine on our end. I'll confirm that and get back to you.

EDIT: And sorry if my initial description was lacking. The only part of our build that's failing is the MacOS pipeline, strictly due to the string comparison in the conanfile.py file. As long as that package has been updated, then we're good to go.

@poletti-marco
Copy link
Contributor

SG. Sorry, I'm totally not familiar with conan.
The Fruit conanfile was contributed by a user of Fruit, and I'm trying to maintain it as well as I can but I'm definitely not an expert.

If something is still missing please advise what to do and I can do it.
(e.g. maybe I should cut a new Fruit release before the "conan create"? Or is running that on the existing stable release, as I did now, enough?)

@tt4g
Copy link
Contributor

tt4g commented May 30, 2019

@ph1ll If the version of fruit being installed does not change, please do conan upload.

If the conan recipe provided by the conan community is also found to have build problems, it may do conan upload after correction.
This is because c++ is complex and it is difficult to provide a recipe that can be built successfully in all compiler.

The fix to make the build pass is always provided by the contributor, and as soon as it is fixed, it is upload to JFrog so that the conan consumer can use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants